[Maps] Autocomplete for custom color palettes and custom icon palettes #56446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:enhancement
WIP
|
Pinging @elastic/kibana-gis (Team:Geo) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
jsanz
approved these changes
Feb 3, 2020
x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_style_property.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/components/stop_input.js
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
Really cool addition.
I think there's a small bug when dealing with a field-selection change.
Steps:
- select a string-field in by-value styling
- select "custom palette" and enter some stop values using the auto-complete
- select a different string-field
- use drop-down to modify existing value in a stop (or add new stop and use drop-down)
-> the auto-complete shows options from the field selected in (1)
(typing in to trigger a new "suggestion-load" will start showing correct suggestions).
Thanks for pointing this out. I have pushed a fix. I found this article about using I think we should use this pattern in other places where we rely on |
thomasneirynck
approved these changes
Feb 12, 2020
| @@ -58,6 +58,7 @@ export const ColorStopsCategorical = ({ | |||
|
|
|||
| return ( | |||
| <StopInput | |||
| key={field.getName()} // force new component instance when field changes | |||
There was a problem hiding this comment.
this is really clever
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 12, 2020
elastic#56446) * [Maps] type ahead for stop values for custom color maps and custom icon maps * use Popover to show type ahead suggestions * datalist version * use EuiComboBox * clean up * wire ColorStopsCategorical to use StopInput component for autocomplete * clean up * cast suggestion values to string so boolean fields work * review feedback * fix problem with stall suggestions from previous field Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Feb 12, 2020
#56446) (#57504) * [Maps] type ahead for stop values for custom color maps and custom icon maps * use Popover to show type ahead suggestions * datalist version * use EuiComboBox * clean up * wire ColorStopsCategorical to use StopInput component for autocomplete * clean up * cast suggestion values to string so boolean fields work * review feedback * fix problem with stall suggestions from previous field Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 13, 2020
…ibana into backport/7.x/pr-57404 * 'backport/7.x/pr-57404' of https://github.com/gmmorris/kibana: [Maps] Autocomplete for custom color palettes and custom icon palettes (elastic#56446) (elastic#57504) Add "coerce" to dev tools autocomplete (elastic#56862) (elastic#57498) [DOCS] Fixes typo in release highlights (elastic#57487)
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 13, 2020
* master: (22 commits) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) [Maps] do not show border color for icon in legend when border width is zero (elastic#57501) refactors 'data-providers' tests (elastic#57474) add `absolute` option to `getUrlForApp` (elastic#57193) [Telemetry] Migrate public to NP (elastic#56285) address flaky test where instances might have different start… (elastic#57506) fix(NA): support legacy plugins path in plugins (elastic#57472) build immutable bundles for new platform plugins (elastic#53976) [SIEM] [Detection Engine] Reject if duplicate rule_id in request payload (elastic#57057) Add autocomplete="off" for input type="password" to appease the scanners (elastic#56922) Use default spaces suffix for signals index if spaces disabled (elastic#57244) [Alerting] Create alert design cleanup (elastic#56929) Management Api - add to migration guide (elastic#56892) fixing maps (elastic#56706) [Maps] Autocomplete for custom color palettes and custom icon palettes (elastic#56446) [Alerting] make actionGroup name's i18n-able (elastic#57404) fixed flaky test (elastic#57490) ... # Conflicts: # src/legacy/core_plugins/telemetry/public/components/__snapshots__/telemetry_form.test.js.snap # src/plugins/telemetry/public/components/telemetry_management_section.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #54921 and #56049